Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/18664#discussion_r144300232 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala --- @@ -31,7 +31,8 @@ object ArrowUtils { // todo: support more types. - def toArrowType(dt: DataType): ArrowType = dt match { + /** Maps data type from Spark to Arrow. NOTE: timeZoneId required for TimestampTypes */ + def toArrowType(dt: DataType, timeZoneId: Option[String]): ArrowType = dt match { --- End diff -- Ok. Makes sense. If this arg is required. We should maybe make it just `String` instead of `Option[String]`, I find having a required arg to be `Option` is not intuitive..
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org