Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18664#discussion_r145037361
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala
---
@@ -55,6 +55,12 @@ object ArrowWriter {
case (DoubleType, vector: NullableFloat8Vector) => new
DoubleWriter(vector)
case (StringType, vector: NullableVarCharVector) => new
StringWriter(vector)
case (BinaryType, vector: NullableVarBinaryVector) => new
BinaryWriter(vector)
+ case (DateType, vector: NullableDateDayVector) => new
DateWriter(vector)
+ case (TimestampType, vector: NullableTimeStampMicroTZVector)
+ // TODO: Should be able to access timezone from vector
+ if field.getType.isInstanceOf[ArrowType.Timestamp] &&
+ field.getType.asInstanceOf[ArrowType.Timestamp].getTimezone !=
null =>
--- End diff --
Do we need this `if`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
