Github user ArtRand commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19374#discussion_r144682661
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ---
    @@ -896,8 +913,8 @@ private[spark] class MesosClusterScheduler(
         revive()
       }
     
    -  private def addDriverToPending(desc: MesosDriverDescription, taskId: 
String) = {
    -    pendingRetryDriversState.persist(taskId, desc)
    +  private def addDriverToPending(desc: MesosDriverDescription, id: String) 
= {
    +    pendingRetryDriversState.persist(id, desc)
    --- End diff --
    
    Maybe keep the name as `subId` because it could be confusing otherwise.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to