Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r145292254
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -135,22 +135,24 @@ private[spark] class MesosClusterScheduler(
private val useFetchCache =
conf.getBoolean("spark.mesos.fetchCache.enable", false)
private val schedulerState = engineFactory.createEngine("scheduler")
private val stateLock = new Object()
+ // Keyed by submission id
private val finishedDrivers =
new mutable.ArrayBuffer[MesosClusterSubmissionState](retainedDrivers)
private var frameworkId: String = null
- // Holds all the launched drivers and current launch state, keyed by
driver id.
+ // Holds all the launched drivers and current launch state, keyed by
submission id.
private val launchedDrivers = new mutable.HashMap[String,
MesosClusterSubmissionState]()
// Holds a map of driver id to expected slave id that is passed to Mesos
for reconciliation.
// All drivers that are loaded after failover are added here, as we need
get the latest
- // state of the tasks from Mesos.
+ // state of the tasks from Mesos. Keyed by task Id.
private val pendingRecover = new mutable.HashMap[String, SlaveID]()
- // Stores all the submitted drivers that hasn't been launched.
+ // Stores all the submitted drivers that hasn't been launched, keyed by
submission id
private val queuedDrivers = new ArrayBuffer[MesosDriverDescription]()
- // All supervised drivers that are waiting to retry after termination.
+ // All supervised drivers that are waiting to retry after termination,
keyed by submission id
private val pendingRetryDrivers = new
ArrayBuffer[MesosDriverDescription]()
private val queuedDriversState =
engineFactory.createEngine("driverQueue")
private val launchedDriversState =
engineFactory.createEngine("launchedDrivers")
private val pendingRetryDriversState =
engineFactory.createEngine("retryList")
+ private final val RETRY_ID = "-retry-"
--- End diff --
Sorry, super nit, maybe `RETRY_SEP`. Feel free to ignore.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
