Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19508#discussion_r145323960 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/compressionSchemes.scala --- @@ -495,6 +474,8 @@ private[columnar] case object DictionaryEncoding extends CompressionScheme { columnType.dataType match { case _: IntegerType => val dictionaryIds = columnVector.reserveDictionaryIds(capacity) + val intDictionary = dictionary.map(_.asInstanceOf[Int]) --- End diff -- @viirya Could you please see [this comment](https://github.com/apache/spark/pull/18704#discussion_r138363222) to avoid unboxing? IIUC, this code still causes unboxing. What do you think?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org