Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19508#discussion_r145329814
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/compressionSchemes.scala
 ---
    @@ -495,6 +474,8 @@ private[columnar] case object DictionaryEncoding 
extends CompressionScheme {
           columnType.dataType match {
             case _: IntegerType =>
               val dictionaryIds = columnVector.reserveDictionaryIds(capacity)
    +          val intDictionary = dictionary.map(_.asInstanceOf[Int])
    --- End diff --
    
    I didn't notice that comment. Let me check it then. If we can't avoid, I 
will revert this and only remove the unused method. Thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to