Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19529#discussion_r146185476
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
    @@ -52,249 +36,23 @@ import org.apache.spark.util.{UninterruptibleThread, 
Utils}
      * Subclasses should *not* create `SQLContext`s in the test suite 
constructor, which is
      * prone to leaving multiple overlapping 
[[org.apache.spark.SparkContext]]s in the same JVM.
      */
    -private[sql] trait SQLTestUtils
    -  extends SparkFunSuite with Eventually
    -  with BeforeAndAfterAll
    -  with SQLTestData
    -  with PlanTest { self =>
    -
    -  protected def sparkContext = spark.sparkContext
    -
    +private[sql] trait SQLTestUtils extends SparkFunSuite with 
SQLTestUtilsBase with PlanTest {
    --- End diff --
    
    Same general comment as PlanTestBase vs PlanTest above


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to