Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19529
  
    I found a very simple way to reduce the line of changes. 
    
    Could you put the PlanTest and PlanTestBase in the same file? We can 
refactor it later, if necessary. For example, in `PlanTest.scala`
    ```Scala
    /**
     * Provides helper methods for comparing plans.
     */
    trait PlanTest extends SparkFunSuite with PlanTestBase
    
    /**
     * Provides helper methods for comparing plans, but without the overhead of
     * mandating a FunSuite.
     */
    trait PlanTestBase extends PredicateHelper { self: Suite =>
    ```
    
    You also can do the same thing for the other files.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to