Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r146473582
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala
---
@@ -59,8 +59,7 @@ private[yarn] class AMCredentialRenewer(
private var lastCredentialsFileSuffix = 0
private val credentialRenewer =
- Executors.newSingleThreadScheduledExecutor(
- ThreadUtils.namedThreadFactory("Credential Refresh Thread"))
+ ThreadUtils.newDaemonSingleThreadScheduledExecutor("Credential Refresh
Thread")
--- End diff --
I generally agree, but I did this mostly to keep these two classes as
congruent as possible. I can change it back if you feel strongly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
