Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19272#discussion_r146622564
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala
 ---
    @@ -59,8 +59,7 @@ private[yarn] class AMCredentialRenewer(
       private var lastCredentialsFileSuffix = 0
     
       private val credentialRenewer =
    -    Executors.newSingleThreadScheduledExecutor(
    -      ThreadUtils.namedThreadFactory("Credential Refresh Thread"))
    +    ThreadUtils.newDaemonSingleThreadScheduledExecutor("Credential Refresh 
Thread")
    --- End diff --
    
    It's ok since you've done it, I was mostly making a generic comment.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to