Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2711#discussion_r18663528
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
@@ -38,6 +40,20 @@ object CommandUtils extends Logging {
command.arguments
}
+ def buildEnvironment(command: Command): Map[String, String] = {
+ val libraryPathEntries = command.libraryPathEntries
+ if (libraryPathEntries.nonEmpty) {
+ val libraryPath = Utils.libraryPath
+ val pathSeparator = File.pathSeparator
+ val sysLibraryPath = sys.env.get(libraryPath)
--- End diff --
Hmmm... I wonder if this should be done. The way it is, the code creating
the `Command` instance can choose the command's environment (e.g., it can set
it to `sys.env` to inherit the environment or can create something completely
different). Here you're forcing the caller's environment onto the child
`Command`...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
