Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2711#discussion_r18663724
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
@@ -38,6 +40,20 @@ object CommandUtils extends Logging {
command.arguments
}
+ def buildEnvironment(command: Command): Map[String, String] = {
--- End diff --
I feel like this would be better in either of the following forms:
* If `Command.environment` already did this automatically, but I don't know
if you can do that in a case class constructor
* If this method were in the `Command` class itself and the `environment`
field were private.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
