Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r148095844
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -354,6 +356,41 @@ class GBTClassifierSuite extends SparkFunSuite with
MLlibTestSparkContext
}
/////////////////////////////////////////////////////////////////////////////
+ // Tests of feature subset strategy
+
/////////////////////////////////////////////////////////////////////////////
+ test("Tests of feature subset strategy") {
+ val numClasses = 2
+ val gbt = new GBTClassifier()
--- End diff --
Not sure if we need these tests. We already test the
`featureSubsetStrategy` in the RandomForest implementation. At any rate, let's
not set parameters that aren't strictly relevant to the test (stepSize,
impurity, etc...).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
