Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18118#discussion_r148065729
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala 
---
    @@ -118,11 +119,12 @@ class DecisionTreeRegressor @Since("1.4.0") 
(@Since("1.4.0") override val uid: S
     
       /** (private[ml]) Train a decision tree on an RDD */
       private[ml] def train(data: RDD[LabeledPoint],
    -      oldStrategy: OldStrategy): DecisionTreeRegressionModel = {
    +      oldStrategy: OldStrategy, featureSubsetStrategy: String): 
DecisionTreeRegressionModel = {
    --- End diff --
    
    follow Spark style here
    
    ```scala
      private[ml] def train(
          data: RDD[LabeledPoint],
          oldStrategy: OldStrategy,
          featureSubsetStrategy: String): DecisionTreeRegressionModel = {
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to