Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19272#discussion_r148339089
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
 ---
    @@ -75,6 +78,17 @@ private[spark] class HadoopDelegationTokenManager(
           .toMap
       }
     
    +  def getRenewableDelegationTokens(): Option[RenewableDelegationTokens] = {
    --- End diff --
    
    I'm not too fond of the idea of having two methods for creating tokens 
(this and `obtainDelegationTokens`). One should be enough.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to