Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r149236687
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -58,8 +60,9 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
extends CoarseGrainedSchedulerBackend(scheduler, sc.env.rpcEnv)
with org.apache.mesos.Scheduler with MesosSchedulerUtils {
- override def hadoopDelegationTokenManager:
Option[HadoopDelegationTokenManager] =
- Some(new HadoopDelegationTokenManager(sc.conf, sc.hadoopConfiguration))
+ private lazy val hadoopCredentialRenewer: MesosCredentialRenewer =
+ new MesosCredentialRenewer(
+ conf, new HadoopDelegationTokenManager(sc.conf,
sc.hadoopConfiguration))
--- End diff --
Why pass in a `HadoopDelegationTokenManager` if it's not used by this
class? The renewer can create one itself.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
