Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2344#discussion_r18685528
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala 
---
    @@ -181,6 +181,18 @@ case object TimestampType extends NativeType {
       def simpleString: String = "timestamp"
     }
     
    +case object DateType extends NativeType {
    +  private[sql] type JvmType = Date
    +
    +  @transient private[sql] lazy val tag = ScalaReflectionLock.synchronized 
{ typeTag[JvmType] }
    +
    +  private[sql] val ordering = new Ordering[JvmType] {
    +    def compare(x: Date, y: Date) = x.toString.compareTo(y.toString)
    +  }
    +
    +  def simpleString: String = "date"
    --- End diff --
    
    `simpleString` can be removed now. #2563 renamed this method to `typeName` 
and a default implementation is provided in `DataType`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to