Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18698063
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -190,6 +190,24 @@ private[sql] class StringColumnStats extends
ColumnStats {
def collectedStatistics = Row(lower, upper, nullCount)
}
+private[sql] class DateColumnStats extends ColumnStats {
+ var upper: Date = null
+ var lower: Date = null
+ var nullCount = 0
+
+ override def gatherStats(row: Row, ordinal: Int) {
+ if (!row.isNullAt(ordinal)) {
+ val value = row(ordinal).asInstanceOf[Date]
+ if (upper == null || value.toString.compareTo(upper.toString) > 0)
upper = value
+ if (lower == null || value.toString.compareTo(lower.toString) < 0)
lower = value
--- End diff --
Using `.getTime` to do the comparison would be much more efficient. When
caching a `DateType` column, this function is really a critical path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
