Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2734#discussion_r18686261
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -34,16 +34,15 @@ case class Aggregator[K, V, C] (
mergeValue: (C, V) => C,
mergeCombiners: (C, C) => C) {
- private val externalSorting =
SparkEnv.get.conf.getBoolean("spark.shuffle.spill", true)
+ private val externalSorting =
SparkEnv.get.conf.getBoolean("spark.shuffle.spill", defaultValue = true)
@deprecated("use combineValuesByKey with TaskContext argument", "0.9.0")
def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]]):
Iterator[(K, C)] =
combineValuesByKey(iter, null)
- def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]],
- context: TaskContext): Iterator[(K, C)] = {
+ def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]], context:
TaskContext): Iterator[(K, C)] = {
--- End diff --
can line length limit increase to 120 or more.
now the screen is bigger.
does long line code affect the compiling result and affect the program
performance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
