Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2734#discussion_r18689129
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -34,16 +34,15 @@ case class Aggregator[K, V, C] (
mergeValue: (C, V) => C,
mergeCombiners: (C, C) => C) {
- private val externalSorting =
SparkEnv.get.conf.getBoolean("spark.shuffle.spill", true)
+ private val externalSorting =
SparkEnv.get.conf.getBoolean("spark.shuffle.spill", defaultValue = true)
--- End diff --
Yes, I understand the logic. My IDE does this automatically without having
to write it out, and I suspect that is true of many if not all other devs. I
also don't see this as common practice in other Scala code. Still I'd be
interested what other people think of this standard, specifically for `Boolean`
args with default value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
