Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19726#discussion_r150408083
  
    --- Diff: python/pyspark/sql/session.py ---
    @@ -182,6 +185,7 @@ def getOrCreate(self):
                         session.sparkContext._conf.set(key, value)
                     return session
     
    +    #: class variable for :class:`Builder` shared by all 
:class:`SparkSession` instances
    --- End diff --
    
    I think we should rather stick to:
    
    ```
    attr = 123
    """ docstring """
    ```
    
    assuming from https://stackoverflow.com/a/9558703. It sounds more closer to 
PEP8. AFAIK, `#:` is Sphinx specific syntax. The case above should also be 
recognisable in Sphinx as well.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to