Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19208#discussion_r150621222
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -301,11 +395,29 @@ object CrossValidatorModel extends
MLReadable[CrossValidatorModel] {
val (metadata, estimator, evaluator, estimatorParamMaps) =
ValidatorParams.loadImpl(path, sc, className)
+ val numFolds = (metadata.params \ "numFolds").extract[Int]
val bestModelPath = new Path(path, "bestModel").toString
val bestModel =
DefaultParamsReader.loadParamsInstance[Model[_]](bestModelPath, sc)
val avgMetrics = (metadata.metadata \
"avgMetrics").extract[Seq[Double]].toArray
+ val shouldPersistSubModels = (metadata.metadata \
"persistSubModels").extract[Boolean]
--- End diff --
I realized this will not be backwards compatible. Let's make this
persistSubModels optional so that we assume it is false if it is not in the
metadata.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
