Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r150731403 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala --- @@ -177,7 +202,9 @@ class TrainValidationSplit @Since("1.5.0") (@Since("1.5.0") override val uid: St } @Since("2.0.0") - override def write: MLWriter = new TrainValidationSplit.TrainValidationSplitWriter(this) + override def write: TrainValidationSplit.TrainValidationSplitWriter = { --- End diff -- Ah, there is two `write` method, one for `Estimator` and another for `Model`. We only need to change the return type of `write` method for `model`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org