Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150845467
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +44,14 @@ class StaticMemoryManagerSuite extends
MemoryManagerSuite {
override protected def createMemoryManager(
maxOnHeapExecutionMemory: Long,
- maxOffHeapExecutionMemory: Long): StaticMemoryManager = {
+ maxOffHeapExecutionMemory: Long = 1000): StaticMemoryManager = {
+ val offHeapSize = conf.get(MEMORY_OFFHEAP_SIZE)
--- End diff --
Why read this conf? we always get default value here, don't we?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
