Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17436#discussion_r150845551
  
    --- Diff: 
core/src/test/scala/org/apache/spark/memory/UnifiedMemoryManagerSuite.scala ---
    @@ -40,10 +42,12 @@ class UnifiedMemoryManagerSuite extends 
MemoryManagerSuite with PrivateMethodTes
       override protected def createMemoryManager(
           maxOnHeapExecutionMemory: Long,
           maxOffHeapExecutionMemory: Long): UnifiedMemoryManager = {
    +    val offHeapSize = sc.get(MEMORY_OFFHEAP_SIZE)
    --- End diff --
    
    I think we always get default value here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to