Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19390#discussion_r151520818
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
 ---
    @@ -175,17 +176,39 @@ trait MesosSchedulerUtils extends Logging {
         registerLatch.countDown()
       }
     
    -  def createResource(name: String, amount: Double, role: Option[String] = 
None): Resource = {
    +  private def setAllocationAndReservationInfo(
    +       allocationInfo: Option[AllocationInfo],
    +       reservationInfo: Option[ReservationInfo],
    +       role: Option[String],
    +       builder: Resource.Builder): Unit = {
    +    if (role.forall(r => !r.equals(ANY_ROLE))) {
    --- End diff --
    
    `.forall(_ != ANY_ROLE)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to