Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r151862273
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -228,24 +254,15 @@ trait MesosSchedulerUtils extends Logging {
(attr.getName, attr.getText.getValue.split(',').toSet)
}
-
- /** Build a Mesos resource protobuf object */
- protected def createResource(resourceName: String, quantity: Double):
Protos.Resource = {
- Resource.newBuilder()
- .setName(resourceName)
- .setType(Value.Type.SCALAR)
- .setScalar(Value.Scalar.newBuilder().setValue(quantity).build())
- .build()
- }
-
/**
* Converts the attributes from the resource offer into a Map of name to
Attribute Value
* The attribute values are the mesos attribute types and they are
*
* @param offerAttributes the attributes offered
* @return
*/
- protected def toAttributeMap(offerAttributes: JList[Attribute]):
Map[String, GeneratedMessage] = {
+ protected def toAttributeMap(offerAttributes: JList[Attribute])
+ : Map[String, GeneratedMessageV3] = {
--- End diff --
https://github.com/databricks/scala-style-guide
"For method declarations, use 4 space indentation for its parameters when
they don't fit in a single line. Return types can be either on the same line as
the last parameter, or put to next line with 2 space indent."
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
