Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19799#discussion_r152799632
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -862,17 +859,17 @@ class VersionsSuite extends SparkFunSuite with
Logging {
| "logicalType": "decimal"
| }
| ]
- | } ]
+ | }]
|}
""".stripMargin
- val schemaUrl = s"""$schemaPath${File.separator}avroDecimal.avsc"""
- val schemaFile = new File(schemaPath, "avroDecimal.avsc")
+ val schemaFile = new File(dir, "avroDecimal.avsc")
val writer = new PrintWriter(schemaFile)
writer.write(avroSchema)
writer.close()
+ val schemaPath = schemaFile.getCanonicalPath
--- End diff --
Leaving it as is is okay to me actually. I can fix them in a batch with
more descriptions and explanation next time. We don't run Scala tests on
Windows anyway as a requirement.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
