Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r153185862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -111,11 +110,12 @@ private [sql] object GenArrayData {
"""
}
- ("",
+ (s"$arrayName = new Object[$numElements];",
--- End diff --
we still create an object array every time here, which doesn't help with
the GC. I think we can just create a local variable here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
