Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r153187131
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -845,4 +845,24 @@ class CastSuite extends SparkFunSuite with
ExpressionEvalHelper {
val outputOuter = Row.fromSeq((1 to N).map(_ => outputInner))
checkEvaluation(cast(Literal.create(inputOuter, fromOuter), toOuter),
outputOuter)
}
+
+ test("SPARK-22570: should not create a lot of instance variables") {
--- End diff --
In the future we may fold global variables to arrays, and these tests
become useless. I think a more reliable way is: check the number of global
variables in `CodegenContext`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
