Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155038714
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2744,6 +2744,25 @@ private[spark] object Utils extends Logging {
}
}
+ /**
+ * Check the validity of the given Kubernetes master URL and return the
resolved URL.
+ */
+ def checkAndGetK8sMasterUrl(rawMasterURL: String): String = {
+ require(rawMasterURL.startsWith("k8s://"),
+ "Kubernetes master URL must start with k8s://.")
+ val masterWithoutK8sPrefix = rawMasterURL.substring("k8s://".length)
--- End diff --
With the changes, URLs like `k8s://host:port` is no longer valid as the
part `host:port` is parsed as a URI with a `host` scheme. Instead,
`k8s:///host:port` should be used. I'm not super familiar with URIs, so I'm not
sure if this is desirable. /cc @mccheah @foxish.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
