Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r155042592
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2744,6 +2744,25 @@ private[spark] object Utils extends Logging {
         }
       }
     
    +  /**
    +   * Check the validity of the given Kubernetes master URL and return the 
resolved URL.
    +   */
    +  def checkAndGetK8sMasterUrl(rawMasterURL: String): String = {
    +    require(rawMasterURL.startsWith("k8s://"),
    +      "Kubernetes master URL must start with k8s://.")
    +    val masterWithoutK8sPrefix = rawMasterURL.substring("k8s://".length)
    --- End diff --
    
    This decision is to match how Mesos works with Zookeeper, as these Strings 
are valid IIRC: `mesos://zk://host1:2181,host2:2181,host3:2181/mesos`. That's 
just the precedent we are using, but we can use a different convention.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to