Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2087#discussion_r18796643
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -121,6 +125,31 @@ class SparkHadoopUtil extends Logging {
         UserGroupInformation.loginUserFromKeytab(principalName, keytabFilename)
       }
     
    +  /**
    +   * Returns a function that can be called to find the number of Hadoop 
FileSystem bytes read by
    +   * this thread so far. Reflection is required because thread-level 
FileSystem statistics are only
    +   * available as of Hadoop 2.5 (see HADOOP-10688). Returns None if the 
required method can't be
    +   * found.
    +   */
    +  def getInputBytesReadCallback(path: Path, conf: Configuration): 
Option[() => Long] = {
    +    val qualifiedPath = path.getFileSystem(conf).makeQualified(path)
    +    val scheme = qualifiedPath.toUri().getScheme()
    +    val stats = 
FileSystem.getAllStatistics().filter(_.getScheme().equals(scheme))
    --- End diff --
    
    When will a specific FileSystem be present here? Is it definitely the case 
that there will exist a fileysystem for the supplied scheme? It looks like this 
is based on a static cache within the FileSystem class. Does that get populated 
before this is invoked?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to