Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2087#discussion_r18832748
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
    @@ -222,12 +221,33 @@ class HadoopRDD[K, V](
               case eof: EOFException =>
                 finished = true
             }
    +
    +        // Update bytes read metric every 32 records
    +        if (recordsSinceMetricsUpdate == 32 && 
bytesReadCallback.isDefined) {
    +          recordsSinceMetricsUpdate = 0
    +          inputMetrics.bytesRead = bytesReadCallback.get()
    --- End diff --
    
    This compiles for me and apparently gets interpreted as 
`(bytesReadCallback.get)()`.  Agreed that this looks weird.  Is there a 
phrasing you think would be best?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to