Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155214151
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -91,16 +91,19 @@ case class Coalesce(children: Seq[Expression]) extends
Expression {
val codes = ctx.splitExpressionsWithCurrentInputs(
expressions = evals,
funcName = "coalesce",
+ returnType = ctx.javaType(dataType),
makeSplitFunction = func =>
s"""
+ |${ctx.javaType(dataType)} ${ev.value} =
${ctx.defaultValue(dataType)};
--- End diff --
make a `resultType` for `ctx.javaType(dataType)`? it appears 3 times...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
