Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155243262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -212,59 +213,63 @@ case class CaseWhen(
val res = elseExpr.genCode(ctx)
s"""
|${res.code}
- |${ev.isNull} = ${res.isNull};
- |${ev.value} = ${res.value};
+ |$resultState = (byte)(${res.isNull} ? 1 : 0);
+ |$tmpResult = ${res.value};
""".stripMargin
}
val allConditions = cases ++ elseCode
// This generates code like:
- // conditionMet = caseWhen_1(i);
- // if(conditionMet) {
+ // caseWhenResultIsNull = caseWhen_1(i);
--- End diff --
these need to be updated
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
