Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19971#discussion_r156839515
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
    @@ -353,8 +355,11 @@ class TPCDSQuerySuite extends QueryTest with 
SharedSQLContext with BeforeAndAfte
           classLoader = Thread.currentThread().getContextClassLoader)
         test(name) {
           withSQLConf(SQLConf.CROSS_JOINS_ENABLED.key -> "true") {
    -        // Just check the plans can be properly generated
    -        sql(queryString).queryExecution.executedPlan
    +        // check the plans can be properly generated
    +        val p = sql(queryString).queryExecution.executedPlan
    +        // check the generated code can be properly compiled
    +        val codes = debug.codegenCodeAndCommentSeq(p)
    +        codes.map(c => CodeGenerator.compile(c))
    --- End diff --
    
    Is it helpful to show up the subtree which causes the compilation error?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to