Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19971#discussion_r156860978
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
    @@ -348,13 +351,38 @@ class TPCDSQuerySuite extends QueryTest with 
SharedSQLContext with BeforeAndAfte
         "q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
         "q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
     
    +  private def checkGeneratedCode(plan: SparkPlan): Unit = {
    +    val codegenSubtrees = new 
collection.mutable.HashSet[WholeStageCodegenExec]()
    +    plan foreach {
    +      case s: WholeStageCodegenExec =>
    +        codegenSubtrees += s
    +      case s => s
    +    }
    +    codegenSubtrees.toSeq.map { subtree =>
    --- End diff --
    
    nit: `map` -> `foreach`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to