Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19974#discussion_r156863889
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -280,4 +280,34 @@ class SQLConfSuite extends QueryTest with
SharedSQLContext {
spark.sessionState.conf.clear()
}
+
+ test("SPARK-22779: correctly compute default value for fallback
configs") {
+ val fallback = SQLConf.buildConf("spark.sql.__test__.spark_22779")
+ .fallbackConf(SQLConf.PARQUET_COMPRESSION)
--- End diff --
In SQLConf, all our conf are `TypedConfigBuilder`, instead of
`ConfigBuilder`. The type-safe ConfigBuilder is unable to call `fallbackConf `,
right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
