Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19974#discussion_r157027896
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
    @@ -280,4 +280,34 @@ class SQLConfSuite extends QueryTest with 
SharedSQLContext {
     
         spark.sessionState.conf.clear()
       }
    +
    +  test("SPARK-22779: correctly compute default value for fallback 
configs") {
    +    val fallback = SQLConf.buildConf("spark.sql.__test__.spark_22779")
    +      .fallbackConf(SQLConf.PARQUET_COMPRESSION)
    --- End diff --
    
    I think at least this is good for renaming. In the future, if we rename the 
SQLConf, we can use this mechanism. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to