Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156875814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -60,38 +60,32 @@ object GenerateMutableProjection extends
CodeGenerator[Seq[Expression], MutableP
val projectionCodes = exprVals.zip(index).map {
--- End diff --
now it's better to explicit write down the type, e.g. `val projectionCodes:
Seq[...]` and explain the meaning
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
