Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1014,12 +1013,12 @@ case class FromUTCTimestamp(left: Expression,
right: Expression)
|long ${ev.value} = 0;
""".stripMargin)
} else {
- val tzTerm = ctx.freshName("tz")
- val utcTerm = ctx.freshName("utc")
val tzClass = classOf[TimeZone].getName
val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
- ctx.addMutableState(tzClass, tzTerm, s"""$tzTerm =
$dtu.getTimeZone("$tz");""")
- ctx.addMutableState(tzClass, utcTerm, s"""$utcTerm =
$dtu.getTimeZone("UTC");""")
+ val tzTerm = ctx.addMutableState(tzClass, "tz",
+ v => s"""$v = $dtu.getTimeZone("$tz");""")
--- End diff --
nit: can be `s"..."`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
