Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19681#discussion_r157015987
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -455,9 +457,14 @@ class SparkContext(config: SparkConf) extends Logging {
// For tests, do not enable the UI
None
}
- // Bind the UI before starting the task scheduler to communicate
- // the bound port to the cluster manager properly
- _ui.foreach(_.bind())
+ _ui.foreach { ui =>
+ // Load any plugins that might want to modify the UI.
+ AppStatusPlugin.loadPlugins().foreach(_.setupUI(ui))
--- End diff --
@vanzin the live UI doesn't need a 2-step process to set up the UI, while
history server needs. That's why I think they should not share one plugin
interface.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
