GitHub user mrkm4ntr opened a pull request:
https://github.com/apache/spark/pull/19988
[Spark-22795] Raise error when line search in FirstOrderMinimizer failed
## What changes were proposed in this pull request?
When line search in FirstOrderMinimizer (LBFGS or OWLQN so on) failed, the
fit method of estimator not failed, and a meaning-less transformer is returned.
This pull request changes estimators to raise an error when line search
failed.
The error should be discovered early.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mrkm4ntr/spark spark-22795
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19988
----
commit b48debb1f5b7d6ec0a44e5c4806f20ee9d6806d9
Author: Shintaro Murakami <[email protected]>
Date: 2017-12-15T05:40:14Z
[Spark-22795] Raise error when line search in FirstOrderMinimizer failed
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
