Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19988#discussion_r157204396
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -109,6 +109,11 @@ private[optim] class QuasiNewtonSolver(
state = states.next()
arrayBuilder += state.adjustedValue
}
+ if (state == null || state.searchFailed) {
+ val msg = s"${optimizer.getClass.getName} failed."
+ logError(msg)
--- End diff --
Warning actually seems more appropriate in all of these cases. It's not an
unrecoverable Spark error.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
