Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19954#discussion_r157321761
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigurationStepsOrchestrator.scala
 ---
    @@ -116,10 +122,53 @@ private[spark] class 
DriverConfigurationStepsOrchestrator(
           None
         }
     
    +    val mayBeInitContainerBootstrapStep =
    +      if (areAnyFilesNonContainerLocal(sparkJars ++ sparkFiles)) {
    +        val initContainerConfigurationStepsOrchestrator =
    --- End diff --
    
    The variable names in this code are very long in general; verbosity can 
both help and harm readability, in this case I don't think it's helping much. 
For example, `orchestrator` is just as good a name for this variable, since 
there's no other orchestrator being used here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to