Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19954#discussion_r157322696
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesFileUtils.scala
---
@@ -47,6 +47,18 @@ private[spark] object KubernetesFileUtils {
}
}
+ /**
+ * Get from a given collection of file URIs the ones that represent
remote files.
+ */
+ def getOnlyRemoteFiles(uris: Iterable[String]): Iterable[String] = {
+ filterUriStringsByScheme(uris, scheme => scheme != "file" && scheme !=
"local")
+ }
+
+ private def filterUriStringsByScheme(
+ uris: Iterable[String], schemeFilter: (String => Boolean)):
Iterable[String] = {
--- End diff --
One param per line for multi-line signatures. But why not inline this since
it's only called in one place?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
