Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18909075
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -33,30 +34,25 @@ import org.apache.spark.util.Utils
* a layer over the different cluster managers and deploy modes that Spark
supports.
*/
object SparkSubmit {
-
- // Cluster managers
- private val YARN = 1
- private val STANDALONE = 2
- private val MESOS = 4
- private val LOCAL = 8
- private val ALL_CLUSTER_MGRS = YARN | STANDALONE | MESOS | LOCAL
-
- // Deploy modes
- private val CLIENT = 1
- private val CLUSTER = 2
- private val ALL_DEPLOY_MODES = CLIENT | CLUSTER
-
// A special jar name that indicates the class being run is inside of
Spark itself, and therefore
// no user jar is needed.
- private val SPARK_INTERNAL = "spark-internal"
+ val SPARK_INTERNAL = "spark-internal"
// Special primary resource names that represent shells rather than
application jars.
- private val SPARK_SHELL = "spark-shell"
- private val PYSPARK_SHELL = "pyspark-shell"
+ val SPARK_SHELL = "spark-shell"
+ val PYSPARK_SHELL = "pyspark-shell"
+
+ // Special python classes
+ val PY4J_GATEWAYSERVER: String = "py4j.GatewayServer"
+ val PYTHON_RUNNER: String = "org.apache.spark.deploy.PythonRunner"
--- End diff --
Instead, I'd use `PythonRunner.getClass.getName.stripSuffix("$")`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
