Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/2516#discussion_r18910093 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -397,9 +347,9 @@ object SparkSubmit { * Provides an indirection layer for passing arguments as system properties or flags to * the user's driver program or to downstream launcher tools. */ -private[spark] case class OptionAssigner( - value: String, - clusterManager: Int, - deployMode: Int, - clOption: String = null, - sysProp: String = null) +private[spark] case class OptionAssigner(configKey: String, + clusterManager: Int, --- End diff -- Still broken here too. Style is: def foo( arg1: Blah, arg2: Blah) {
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org