Github user superbobry commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19992#discussion_r158028287
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -444,12 +444,15 @@ private[spark] object JsonProtocol {
         ("Disk Size" -> rddInfo.diskSize)
       }
     
    -  def storageLevelToJson(storageLevel: StorageLevel): JValue = {
    -    ("Use Disk" -> storageLevel.useDisk) ~
    -    ("Use Memory" -> storageLevel.useMemory) ~
    -    ("Deserialized" -> storageLevel.deserialized) ~
    -    ("Replication" -> storageLevel.replication)
    -  }
    +  def storageLevelToJson(storageLevel: StorageLevel): JValue =
    --- End diff --
    
    Sorry, missed it. I've decided not to add braces to `storageLevelFromJson` 
because it seems to look OK with the toplevel match.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to